hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhijie Shen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1659) Define ApplicationTimelineStore interface and store-facing entity, entity-info and event objects
Date Sun, 02 Feb 2014 02:46:09 GMT

    [ https://issues.apache.org/jira/browse/YARN-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888804#comment-13888804
] 

Zhijie Shen commented on YARN-1659:
-----------------------------------

bq. I don't think we should make this change, as the enum values currently match the names
of the optional member variables of the ATSEntity object.

IMO, the renaming mentioned by Vinod is not changing to another name. Instead, it's adjusting
the format to comply with Java convention. For example, RELATEDENTITIES -> RELATED_ENTITIES,
PRIMARYFILTERS -> PRIMARY_FILTERS.

bq. I agree removing Entity is a good idea. I've made the change, and will just wait for Zhijie's
feedback before I upload another patch.

+1 for removing Entity, thought in-memory implementation takes the entity as the key. However,
interface shouldn't depend on the implementation. I can create a inner Entity object instead.
Please go ahead with the change.

> Define ApplicationTimelineStore interface and store-facing entity, entity-info and event
objects
> ------------------------------------------------------------------------------------------------
>
>                 Key: YARN-1659
>                 URL: https://issues.apache.org/jira/browse/YARN-1659
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Billie Rinaldi
>            Assignee: Billie Rinaldi
>         Attachments: YARN-1659-1.patch, YARN-1659-3.patch, YARN-1659-4.patch, YARN-1659-5.patch,
YARN-1659-6.patch, YARN-1659.2.patch
>
>
> These will be used by ApplicationTimelineStore interface.  The web services will convert
the store-facing obects to the user-facing objects.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message