[ https://issues.apache.org/jira/browse/YARN-1553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899448#comment-13899448
]
Haohui Mai commented on YARN-1553:
----------------------------------
bq. In the few places that we used “//“, should we retain the old behavior and explicitly
use the URL with scheme?
This is a general way of handling links for both http and https. Previously we've used your
proposed scheme in the old HDFS UI, it was quite error-prone.
bq. getRMDefaultPortNumber() method should use the new method instead of using RM_SERVICES_ADDRESS_CONF_KEYS_HTTP
directly.
It is a static method so I don't quite see choosing between {{RM_SERVICES_ADDRESS_CONF_KEYS_HTTP}}
/ {{RM_SERVICES_ADDRESS_CONF_KEYS_HTTPS}} are possible. Do you have any idea?
> Do not use HttpConfig.isSecure() in YARN
> ----------------------------------------
>
> Key: YARN-1553
> URL: https://issues.apache.org/jira/browse/YARN-1553
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: YARN-1553.000.patch, YARN-1553.001.patch, YARN-1553.002.patch, YARN-1553.003.patch,
YARN-1553.004.patch, YARN-1553.005.patch, YARN-1553.006.patch
>
>
> HDFS-5305 and related jira decide that each individual project will have their own configuration
on http policy. {{HttpConfig.isSecure}} is a global static method which does not fit the design
anymore. The same functionality should be moved into the YARN code base.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
|