hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1551) Allow user-specified reason for killApplication
Date Tue, 11 Feb 2014 01:23:24 GMT

    [ https://issues.apache.org/jira/browse/YARN-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13897404#comment-13897404
] 

Karthik Kambatla commented on YARN-1551:
----------------------------------------

The patch looks good to me, but for the following nit: 
# If it is not adding anything, I would remove the if-else
{code}
    if (reason == null) {
      client.killApplication(app.getApplicationId());
    } else {
      client.killApplication(app.getApplicationId(), reason);
    }
{code}

Let us wait for [~vinodkv] also to look at it. 

> Allow user-specified reason for killApplication
> -----------------------------------------------
>
>                 Key: YARN-1551
>                 URL: https://issues.apache.org/jira/browse/YARN-1551
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.4.0
>            Reporter: Gera Shegalov
>            Assignee: Gera Shegalov
>         Attachments: YARN-1551.v01.patch, YARN-1551.v02.patch, YARN-1551.v03.patch, YARN-1551.v04.patch,
YARN-1551.v05.patch
>
>
> This completes MAPREDUCE-5648



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message