Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Thu, 16 Jan 2014 08:53:21 +0000 (UTC)
From: "Sandy Ryza (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12682817.1386208393699.14781.1389862401241@arcas>
In-Reply-To: <JIRA.12682817.1386208393699@arcas>
References: <JIRA.12682817.1386208393699@arcas>
Subject: [jira] [Commented] (YARN-1474) Make schedulers services
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13873172#comment-13873172 ] 

Sandy Ryza commented on YARN-1474:
----------------------------------

Overall, the approach looks good to me.  A couple comments about the Fair Scheduler portions.

{code}
+      ((FairScheduler)scheduler).serviceInitInternal(conf);
{code}
No need to cast here, right?  Also, why not just call scheduler.init(conf)?

The Fair Scheduler's serviceStop implementation should that shut down the threads it started.

> Make schedulers services
> ------------------------
>
>                 Key: YARN-1474
>                 URL: https://issues.apache.org/jira/browse/YARN-1474
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: scheduler
>    Affects Versions: 2.4.0
>            Reporter: Sandy Ryza
>            Assignee: Tsuyoshi OZAWA
>         Attachments: YARN-1474.1.patch, YARN-1474.2.patch, YARN-1474.3.patch
>
>
> Schedulers currently have a reinitialize but no start and stop.  Fitting them into the YARN service model would make things more coherent.


--
This message was sent by Atlassian JIRA
(v6.1.5#6160)