hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira AJISAKA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1617) Remove ancient comment and surround LOG.debug in AppSchedulingInfo.allocate
Date Wed, 22 Jan 2014 06:01:21 GMT

    [ https://issues.apache.org/jira/browse/YARN-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878299#comment-13878299
] 

Akira AJISAKA commented on YARN-1617:
-------------------------------------

LGTM, +1. I think the refactoring does not need new tests.

> Remove ancient comment and surround LOG.debug in AppSchedulingInfo.allocate
> ---------------------------------------------------------------------------
>
>                 Key: YARN-1617
>                 URL: https://issues.apache.org/jira/browse/YARN-1617
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: scheduler
>    Affects Versions: 2.2.0
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-1617.patch
>
>
> {code}
>   synchronized private void allocate(Container container) {
>     // Update consumption and track allocations
>     //TODO: fixme sharad
>     /* try {
>         store.storeContainer(container);
>       } catch (IOException ie) {
>         // TODO fix this. we shouldnt ignore
>       }*/
>     
>     LOG.debug("allocate: applicationId=" + applicationId + " container="
>         + container.getId() + " host="
>         + container.getNodeId().toString());
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message