hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuan Gong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once
Date Fri, 10 Jan 2014 03:54:51 GMT

    [ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867473#comment-13867473
] 

Xuan Gong commented on YARN-1574:
---------------------------------

bq. I should have thought of this earlier - we should remove the dispatcher added to the RM's
serviceList (through addIfService) and add the new one as well. Otherwise, we could be creating
a memory leak. Not sure if we could add a unit test for this, but would be nice to make sure
there is no such leak using jmap or something.

fixed

bq.I also noticed CompositeService#removeService is broken. I am okay with fixing that too
in the same JIRA or a different JIRA. Either way, our tests should probably cover that too.

fixed

> When RM transit from Active to Standby, the same eventDispatcher should not be registered
more than once
> --------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-1574
>                 URL: https://issues.apache.org/jira/browse/YARN-1574
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>            Priority: Blocker
>         Attachments: YARN-1574.1.patch, YARN-1574.1.patch, YARN-1574.2.patch, YARN-1574.2.patch,
YARN-1574.3.patch, YARN-1574.4.patch, YARN-1574.5.patch
>
>
> Currently, we move rmDispatcher out of ActiveService. But we still register the Event
dispatcher, such as schedulerDispatcher, RMAppEventDispatcher when we initiate the ActiveService.
> Almost every time when we transit RM from Active to Standby,  we need to initiate the
ActiveService. That means we will register the same event Dispatcher which will cause the
same event will be handled several times.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message