hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1551) Allow user-specified reason for killApplication
Date Tue, 14 Jan 2014 22:23:21 GMT

    [ https://issues.apache.org/jira/browse/YARN-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13871286#comment-13871286
] 

Karthik Kambatla commented on YARN-1551:
----------------------------------------

I am not particular about this, but I think adding reason to killApplication is a YARN-feature
and can be tested in YARN itself. To test the YARN changes, we can add tests to TestClientRMService
and TestYarnClient. ResourceMgrDelegate and TestMRJobs are changes in MR to leverage this
feature can be in an MR JIRA. 

Comments on the patch for YARN changes:
# Can we add InterfaceStability annotations as well as javadoc?
{code}
@Public
public abstract String getReason();

@Public
public abstract void setReason(String reason);
{code}
# Nit: I am not particular on this, instead of a {{null}} reason, something like {[N/A}} might
be better? 
# The constant MAX_KILL_REASON_LENGTH can be private.
# We need separate javadoc for the new method
{code}

+   * @param reason justification for application kill
    * @throws YarnException
    *           in case of errors or if YARN rejects the request due to
    *           access-control restrictions.
    * @throws IOException
    * @see #getQueueAclsInfo()
    */
+  public abstract void killApplication(ApplicationId applicationId,
+      String reason) throws YarnException, IOException;
+
{code}



> Allow user-specified reason for killApplication
> -----------------------------------------------
>
>                 Key: YARN-1551
>                 URL: https://issues.apache.org/jira/browse/YARN-1551
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Gera Shegalov
>            Assignee: Gera Shegalov
>         Attachments: YARN-1551.v01.patch, YARN-1551.v02.patch, YARN-1551.v03.patch
>
>
> This completes MAPREDUCE-5648



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message