hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuan Gong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
Date Tue, 28 Jan 2014 18:45:39 GMT

    [ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13884409#comment-13884409
] 

Xuan Gong commented on YARN-1525:
---------------------------------

Comments:
1.{code}
if (webApp.isStandbyMode() && !uri.equals("/" + webApp.name() + "/cluster")
+        && !uri.equals("/" + webApp.wsName() + "/v1/cluster/info"))
{code}

Can we remote (!uri.equals("/" + webApp.wsName() + "/v1/cluster/info")) here? We can handle
it in ws ticket if needed.

2.In RMWebApp#findRedirectPath, 
{code}
+    if (activeRMHAId != null) {
+      yarnConf.set(YarnConfiguration.RM_HA_ID, activeRMHAId);
+      InetSocketAddress sock =
+          yarnConf.getSocketAddr(YarnConfiguration.RM_WEBAPP_ADDRESS,
+              YarnConfiguration.DEFAULT_RM_WEBAPP_ADDRESS,
+              YarnConfiguration.DEFAULT_RM_WEBAPP_PORT);
+      return sock.getHostName() + ":" + Integer.toString(sock.getPort());
+    }
{code}

If HttpConfig.isSecure() is enable, we will use RM_WEBAPP_HTTPS_ADDRESS instead of RM_WEBAPP_ADDRESS.
So, when we create the redirectPath, we need consider it.

3.For the testcase, current the test case you created is more like a functionality test. Can
you add an end-to-end test (You can use miniYarnCluster) ? Please take a look at TestRMFailover.

4.Also, please click the "submit patch" if you have a new patch available. The jekins will
apply your patch, do several verifications, and make sure that this patch will not break previous
tests.

> Web UI should redirect to active RM when HA is enabled.
> -------------------------------------------------------
>
>                 Key: YARN-1525
>                 URL: https://issues.apache.org/jira/browse/YARN-1525
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Xuan Gong
>            Assignee: Cindy Li
>         Attachments: YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3
>
>
> When failover happens, web UI should redirect to the current active rm.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message