Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EBA441092A for ; Fri, 13 Dec 2013 07:06:14 +0000 (UTC) Received: (qmail 26923 invoked by uid 500); 13 Dec 2013 07:06:10 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 26847 invoked by uid 500); 13 Dec 2013 07:06:09 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 26815 invoked by uid 99); 13 Dec 2013 07:06:08 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Dec 2013 07:06:08 +0000 Date: Fri, 13 Dec 2013 07:06:07 +0000 (UTC) From: "Zhijie Shen (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-1446) Change killing application to wait until state store is done MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847217#comment-13847217 ] Zhijie Shen commented on YARN-1446: ----------------------------------- Two minor comments about the tests: 1. Maybe it's good to write a test case for YarnClient.killApplication, because after the change, it's no longer a single wrap of ApplicationClientProtocol. 2. Also, is it good to test transition to/from KILLING in TestRMAppTransitions > Change killing application to wait until state store is done > ------------------------------------------------------------ > > Key: YARN-1446 > URL: https://issues.apache.org/jira/browse/YARN-1446 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Jian He > Assignee: Jian He > Attachments: YARN-1446.1.patch, YARN-1446.1.patch, YARN-1446.1.patch, YARN-1446.2.patch, YARN-1446.3.patch, YARN-1446.3.patch, YARN-1446.4.patch, YARN-1446.5.patch, YARN-1446.6.patch, YARN-1446.7.patch, YARN-1446.8.patch, YARN-1446.8.patch > > > When user kills an application, it should wait until the state store is done with saving the killed status of the application. Otherwise, if RM crashes in the middle between user killing the application and writing the status to the store, RM will relaunch this application after it restarts. -- This message was sent by Atlassian JIRA (v6.1.4#6159)