Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9282310B7E for ; Wed, 18 Dec 2013 17:47:47 +0000 (UTC) Received: (qmail 38899 invoked by uid 500); 18 Dec 2013 17:47:25 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 38556 invoked by uid 500); 18 Dec 2013 17:47:18 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 38211 invoked by uid 99); 18 Dec 2013 17:47:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Dec 2013 17:47:13 +0000 Date: Wed, 18 Dec 2013 17:47:13 +0000 (UTC) From: "Sandy Ryza (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-1287) Consolidate MockClocks MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13851958#comment-13851958 ] Sandy Ryza commented on YARN-1287: ---------------------------------- Actually just noticed - the MockClock class should go into the test directory, not the main source directory, i.e. it should be under src/test/java. Otherwise the patch LGTM. > Consolidate MockClocks > ---------------------- > > Key: YARN-1287 > URL: https://issues.apache.org/jira/browse/YARN-1287 > Project: Hadoop YARN > Issue Type: Improvement > Reporter: Sandy Ryza > Assignee: Sebastian Wong > Labels: newbie > Attachments: YARN-1287-2.patch > > > A bunch of different tests have near-identical implementations of MockClock. TestFairScheduler, TestFSSchedulerApp, and TestCgroupsLCEResourcesHandler for example. They should be consolidated into a single MockClock. -- This message was sent by Atlassian JIRA (v6.1.4#6159)