hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1513) One message is misleading in LogsCLI
Date Wed, 25 Dec 2013 19:01:50 GMT

    [ https://issues.apache.org/jira/browse/YARN-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13856644#comment-13856644
] 

Hadoop QA commented on YARN-1513:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12620443/YARN-1513.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/2725//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2725//console

This message is automatically generated.

> One message is misleading in LogsCLI
> ------------------------------------
>
>                 Key: YARN-1513
>                 URL: https://issues.apache.org/jira/browse/YARN-1513
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.2.0
>            Reporter: Zhijie Shen
>            Assignee: haosdent
>            Priority: Minor
>             Fix For: 2.2.1
>
>         Attachments: YARN-1513.patch
>
>
> In LogsCLI,
> {code}
>     } else if ((containerIdStr == null && nodeAddress != null)
>         || (containerIdStr != null && nodeAddress == null)) {
>       System.out.println("ContainerId or NodeAddress cannot be null!");
> {code}
> If users set either ContainerId or NodeAddress, but not both, they will get this message.
However, it may confuse the users, because the sentence sounds that it's OK if one of the
two params is not null.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message