hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sandy Ryza (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1493) Schedulers don't recognize apps separately from app-attempts
Date Mon, 16 Dec 2013 21:46:08 GMT

    [ https://issues.apache.org/jira/browse/YARN-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13849761#comment-13849761
] 

Sandy Ryza commented on YARN-1493:
----------------------------------

Thanks for clarifying Jian.

bq. will rename this to SchedulerApplication, and rename the current SchedulerApplication
to SchedulerApplicationAttempt
Do you plan to do that in this patch?  If not, why not?  Right now the class isn't actually
wrapping anything so we should at least change its name.

Didn't do a full review, but a couple things I noticed:

{code}
+    SchedulerApplicationWrapper application =
+        applications.get(applicationAttemptId.getApplicationId());
+    String user =
+        applications.get(applicationAttemptId.getApplicationId()).getUser();
{code}
Should use application to get the user.

{code}
     ApplicationId appId = BuilderUtils.newApplicationId(100, 1);
     ApplicationAttemptId appAttemptId = BuilderUtils.newApplicationAttemptId(
         appId, 1);
-    SchedulerEvent event =
-        new AppAttemptAddedSchedulerEvent(appAttemptId, "default", "user");
-    fs.handle(event);
+    SchedulerEvent appEvent =
+        new AppAddedSchedulerEvent(appAttemptId.getApplicationId(), "default",
+          "user");
{code}
Can use appId instead of appAttemptId.getApplicationId()

> Schedulers don't recognize apps separately from app-attempts
> ------------------------------------------------------------
>
>                 Key: YARN-1493
>                 URL: https://issues.apache.org/jira/browse/YARN-1493
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jian He
>            Assignee: Jian He
>         Attachments: YARN-1493.1.patch
>
>
> Today, scheduler is tied to attempt only.
> We need to separate app-level handling logic in scheduler. We can add new app-level events
to the scheduler and separate the app-level logic out. This is good for work-preserving AM
restart, RM restart, and also needed for differentiating app-level metrics and attempt-level
metrics.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message