hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sandy Ryza (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1448) Protocol changes in RM side to support change container resources
Date Sun, 08 Dec 2013 03:07:35 GMT

    [ https://issues.apache.org/jira/browse/YARN-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842382#comment-13842382
] 

Sandy Ryza commented on YARN-1448:
----------------------------------

The patch overall looks good to me, just a few nits:

{code}
+    if (increaseRequests == null)
+      return;
{code}
{code}
+    if (increasedContainers == null)
+      return;
{code}
Should use curly braces in these places.

{code}
+                throw new UnsupportedOperationException();
+
{code}
Blank line not necessary.

Method annotations should follow similar methods in the same class. I.e. getters should be
Public and Stable and setters should be Private and Unstable.

> Protocol changes in RM side to support change container resources
> -----------------------------------------------------------------
>
>                 Key: YARN-1448
>                 URL: https://issues.apache.org/jira/browse/YARN-1448
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, resourcemanager
>    Affects Versions: 2.2.0
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: yarn-1448.1.patch, yarn-1448.2.patch
>
>
> As described in YARN-1197, we need add API in RM to support
> 1) Add increase request in AllocateRequest
> 2) Can get successfully increased/decreased containers from RM in AllocateResponse



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message