hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuan Gong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1445) Separate FINISHING and FINISHED state in YarnApplicationState
Date Mon, 02 Dec 2013 19:52:35 GMT

    [ https://issues.apache.org/jira/browse/YARN-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836841#comment-13836841
] 

Xuan Gong commented on YARN-1445:
---------------------------------

bq. I've the different opinion here. RMAppImpl actually allows killing the app when it is
in FINISHING. Moreover, if we handle FINISHING in the same way as FINISHED, we will see that
printApplicationReport tells the app is still in FINISHING, while killApplication says the
app is finished. Thoughts?

Make sense

bq. 2. TestYarnClient#testSubmitApplication need to be changed accordingly as well. Would
you please double check other test classes where FINISHED is referred, and check whether the
test cases will be broken or not?

Good catch. Fixed. For other places, I think they are fine. I did the full run on all the
test for hadoop-yarn project. 

bq. 3. Is it good to document the difference in detail between FINISHING and FINISHED

Added

> Separate FINISHING and FINISHED state in YarnApplicationState
> -------------------------------------------------------------
>
>                 Key: YARN-1445
>                 URL: https://issues.apache.org/jira/browse/YARN-1445
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-1445.1.patch, YARN-1445.2.patch, YARN-1445.3.patch
>
>
> Today, we will transmit both RMAppState.FINISHING and RMAppState.FINISHED to YarnApplicationState.FINISHED.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message