hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhijie Shen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1435) Distributed Shell should not run other commands except "sh", and run the custom script at the same time.
Date Mon, 09 Dec 2013 23:44:09 GMT

    [ https://issues.apache.org/jira/browse/YARN-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843710#comment-13843710
] 

Zhijie Shen commented on YARN-1435:
-----------------------------------

bq. Those variables will be used in App.java or Client.java only. I think it should be fine
to define as final

I mean maybe it's better to make these hard code variables static, because they are not altered
in each instances of AM or Client. How do you think?

One other nit:

Is it better to simplify the following code
{code}
+      String shellPathSuffix = "";
+      if (Shell.WINDOWS) {
+        shellPathSuffix =
+            appName + "/" + appId.getId() + "/" + windowBatPath;
+      } else {
+        shellPathSuffix =
+            appName + "/" + appId.getId() + "/" + linuxShellPath;
+      }
{code}
to
{code}
+      String shellPathSuffix =  appName + "/" + appId.getId() + "/" + (Shell.WINDOWS ? windowBatPath
: linuxShellPath);
{code}

> Distributed Shell should not run other commands except "sh", and run the custom script
at the same time.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-1435
>                 URL: https://issues.apache.org/jira/browse/YARN-1435
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications/distributed-shell
>    Affects Versions: 2.3.0
>            Reporter: Tassapol Athiapinya
>            Assignee: Xuan Gong
>         Attachments: YARN-1435.1.patch, YARN-1435.1.patch, YARN-1435.2.patch, YARN-1435.3.patch
>
>
> Currently, if we want to run custom script at DS. We can do it like this :
> --shell_command sh --shell_script custom_script.sh
> But it may be better to separate running shell_command and shell_script



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message