hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mayank Bansal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1413) [YARN-321] AHS WebUI should server aggregated logs as well
Date Thu, 19 Dec 2013 08:38:07 GMT

    [ https://issues.apache.org/jira/browse/YARN-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13852738#comment-13852738

Mayank Bansal commented on YARN-1413:

Thanks [~zjshen] and [~vinodkv] for review
bq. 1. Change "Log" -> "Logs", and should we take care of the case that LogUrl doesn't

bq. 2. Would you please add some test cases in TestAHSWebApp for the aggregated logs page?
You can refer to the other test cases in TestAHSWebApp and TestHSWebApp.
We are using AgreegatedLogs and its test already so not sure we will add any value.

bq. 3. It seems that the logURL construction logic is added in ContainerLogsUtils. And rationale
I am not sure what you are asking here , I think I am only doing it once at RMContainerImpl

bq. BTW, it is tested locally that the aggregated logs page display correctly, right?
Yes I tested it.

bq. BTW, how about keep showing the full logURL on the container page instead of "Logs"?
I think Logs should be fine as its consistent every where.

bq. Please fix formatting too. It's non-standard in many places.

bq. RMContainerImpl has hard-coded "/host:port" ? !


> [YARN-321] AHS WebUI should server aggregated logs as well
> ----------------------------------------------------------
>                 Key: YARN-1413
>                 URL: https://issues.apache.org/jira/browse/YARN-1413
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Zhijie Shen
>            Assignee: Mayank Bansal
>         Attachments: YARN-1413-1.patch, YARN-1413-2.patch, YARN-1413-3.patch

This message was sent by Atlassian JIRA

View raw message