hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sandy Ryza (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1403) Separate out configuration loading from QueueManager in the Fair Scheduler
Date Thu, 05 Dec 2013 00:08:35 GMT

    [ https://issues.apache.org/jira/browse/YARN-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13839523#comment-13839523
] 

Sandy Ryza commented on YARN-1403:
----------------------------------

Thanks for the review. Attaching a patch that makes all the suggested changes except below:

bq. Do we need the 2 constructors? The one receiving the config is a bit misleading as sets
all default values except for placement policy
Placement policy is the only one which can depend on the configuration passed in.  Could just
have the other constructor and instantiate empty versions of everything else when calling
it.  It's called in two places - once in FairScheduler.java and once in a test. The current
way saves a bit of code.

bq. the time value constants should indicate in comments the time out (ms I assume)
Added the time unit (ms) to the variable names to make it clear wherever they're referenced.

bq. If the FSQueue receives a QueueManager, and the QueueManager provides the AllocationConfiguration
(which is updated), then the changes are much less and we don't have to iterate over all FSQueue
instances to set an updated AllocationConfiguration.
The current way avoids a reference/layer of indirection in code that gets touched all the
time by the core scheduling loop.  Maybe not a big deal as the queue manager could be held
in the CPU cache, but would rather err on the side of scheduling latency that reload latency.


> Separate out configuration loading from QueueManager in the Fair Scheduler
> --------------------------------------------------------------------------
>
>                 Key: YARN-1403
>                 URL: https://issues.apache.org/jira/browse/YARN-1403
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.2.0
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-1403-1.patch, YARN-1403-2.patch, YARN-1403-3.patch, YARN-1403.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message