hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuan Gong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1325) Enabling HA should check Configuration contains multiple RMs
Date Mon, 09 Dec 2013 19:32:15 GMT

    [ https://issues.apache.org/jira/browse/YARN-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843449#comment-13843449
] 

Xuan Gong commented on YARN-1325:
---------------------------------

Thanks, [~kkambatl] for the review.

bq. "< 2" might be easier to understand. The error message can also make that explicit
- HA mode requires atleast two RMs.

Changed

bq. verifyAndSetAllRpcAddresses already sets the rpc-addresses. Not sure if we need a new
method.

For the function verifyAndSetAllRpcAddresses, it verify and set the All Rpc Address for the
RMId (original set as current RMId). For the new function I added, I want to check if all
RPC addresses are configured for all the RMIds since they are important for automatically
failover.  But I think that I do not need to set the addresses, verify them should be enough.

bq.  The http secure vs not-secure check can be in verifyAndSetAllRpcAddresses

Did it.

bq. Instead of if - else if - else could use a single if.

fixed.

bq. Instead of copying the string to the test, should probably use a final variable in HAUtil.

changed.

Also, take vinod's suggestion,  rename verifyAndSetRMHAIds to verifyAndSetRMHAIdsList and
verifyAndSetRMHAId to verifyAndSetCurrentRMHAId 

> Enabling HA should check Configuration contains multiple RMs
> ------------------------------------------------------------
>
>                 Key: YARN-1325
>                 URL: https://issues.apache.org/jira/browse/YARN-1325
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Tsuyoshi OZAWA
>            Assignee: Xuan Gong
>              Labels: ha
>         Attachments: YARN-1325.1.patch
>
>
> Currently, we can enable RM HA configuration without multiple RM ids(YarnConfiguration.RM_HA_IDS).
 This behaviour can cause wrong operations. ResourceManager should verify that more than 1
RM id must be specified in RM-HA-IDs.
> One idea is to support "strict mode" to enforce this check as configuration(e.g. yarn.resourcemanager.ha.strict-mode.enabled).



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message