Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 868D010DDB for ; Wed, 13 Nov 2013 15:25:59 +0000 (UTC) Received: (qmail 90451 invoked by uid 500); 13 Nov 2013 15:25:59 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 89982 invoked by uid 500); 13 Nov 2013 15:25:58 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 89837 invoked by uid 99); 13 Nov 2013 15:25:56 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Nov 2013 15:25:56 +0000 Date: Wed, 13 Nov 2013 15:25:56 +0000 (UTC) From: "Thomas Graves (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-1407) apps REST API filters queries by YarnApplicationState, but includes RMAppStates in response MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13821413#comment-13821413 ] Thomas Graves commented on YARN-1407: ------------------------------------- I think it will be fine for backwards compatibility since as you said we are reducing what it could return, so it atleast won't be any new unexpected values. We should update the documentation: http://hadoop.apache.org/docs/r2.2.0/hadoop-yarn/hadoop-yarn-site/ResourceManagerRest.html#Cluster_Application_API. It might be best just to remove the hardcoded valid values and point to the YarnApplicationState for valid states. > apps REST API filters queries by YarnApplicationState, but includes RMAppStates in response > ------------------------------------------------------------------------------------------- > > Key: YARN-1407 > URL: https://issues.apache.org/jira/browse/YARN-1407 > Project: Hadoop YARN > Issue Type: Bug > Affects Versions: 2.2.0 > Reporter: Sandy Ryza > Assignee: Sandy Ryza > Attachments: YARN-1407.patch > > > RMAppState isn't a public facing enum like YarnApplicationState, so we shouldn't return values that come from it. > It is not 100% clear to me whether or not fixing this would be a backwards-incompatible change. The change would only reduce the set of possible strings that the API returns, so I think not. We have also been changing the contents of RMAppState since 2.2.0, e.g. in YARN-891. It would still be good to fix this ASAP (i.e. for 2.2.1). -- This message was sent by Atlassian JIRA (v6.1#6144)