Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7F06B109D2 for ; Tue, 19 Nov 2013 12:39:38 +0000 (UTC) Received: (qmail 19077 invoked by uid 500); 19 Nov 2013 12:39:33 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 18956 invoked by uid 500); 19 Nov 2013 12:39:24 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 18773 invoked by uid 99); 19 Nov 2013 12:39:23 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Nov 2013 12:39:23 +0000 Date: Tue, 19 Nov 2013 12:39:23 +0000 (UTC) From: "Hadoop QA (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-1332) In TestAMRMClient, replace assertTrue with assertEquals where possible MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826442#comment-13826442 ] Hadoop QA commented on YARN-1332: --------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614153/YARN-1332-2.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/2483//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2483//console This message is automatically generated. > In TestAMRMClient, replace assertTrue with assertEquals where possible > ---------------------------------------------------------------------- > > Key: YARN-1332 > URL: https://issues.apache.org/jira/browse/YARN-1332 > Project: Hadoop YARN > Issue Type: Improvement > Affects Versions: 2.2.0 > Reporter: Sandy Ryza > Assignee: Sebastian Wong > Priority: Minor > Labels: newbie > Attachments: YARN-1332-2.patch, YARN-1332.patch > > > TestAMRMClient uses a lot of "assertTrue(amClient.ask.size() == 0)" where "assertEquals(0, amClient.ask.size())" would make it easier to see why it's failing at a glance. -- This message was sent by Atlassian JIRA (v6.1#6144)