Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Wed, 27 Nov 2013 18:25:35 +0000 (UTC)
From: "Karthik Kambatla (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12670592.1380148638092.39642.1385576735580@arcas>
In-Reply-To: <JIRA.12670592.1380148638092@arcas>
References: <JIRA.12670592.1380148638092@arcas>
Subject: [jira] [Commented] (YARN-1241) In Fair Scheduler maxRunningApps
 does not work for non-leaf queues
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13834008#comment-13834008 ] 

Karthik Kambatla commented on YARN-1241:
----------------------------------------

In the latest set of changes:
# If it is not too much of a bother, we should add a test to verify the correctness of counting non-runnable apps. 
# Would be nice to add a message to the exception thrown for better debugging:
{code}
+    @Override
+    public void remove() {
+      throw new UnsupportedOperationException();
+    }
{code}
# Might want to revisit this comment: find *and* gather? 
{code}
+  /**
+   * Traverses the queue hierarchy under the given queue to find gather
+   * all lists of non-runnable applications.
+   */
{code}
# Typo:
{code}
+   * We maintain positions in each of the lists.  Each next() call advances
+   * the position in one of the lists.  We maintain a heap that that orders lists
+   * by the start time of the app in the current position in that list.
{code}

> In Fair Scheduler maxRunningApps does not work for non-leaf queues
> ------------------------------------------------------------------
>
>                 Key: YARN-1241
>                 URL: https://issues.apache.org/jira/browse/YARN-1241
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.1.0-beta
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-1241-1.patch, YARN-1241-10.patch, YARN-1241-2.patch, YARN-1241-3.patch, YARN-1241-4.patch, YARN-1241-5.patch, YARN-1241-6.patch, YARN-1241-7.patch, YARN-1241-8.patch, YARN-1241-9.patch, YARN-1241.patch
>
>
> Setting the maxRunningApps property on a parent queue should make it that the sum of apps in all subqueues can't exceed it


--
This message was sent by Atlassian JIRA
(v6.1#6144)