Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Tue, 5 Nov 2013 23:46:17 +0000 (UTC)
From: "Bikas Saha (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12666077.1377757926765.25133.1383695177850@arcas>
In-Reply-To: <JIRA.12666077.1377757926765@arcas>
References: <JIRA.12666077.1377757926765@arcas>
Subject: [jira] [Commented] (YARN-1121) RMStateStore should flush all
 pending store events before closing
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814410#comment-13814410 ] 

Bikas Saha commented on YARN-1121:
----------------------------------

bq. To do that, we may need to add things in dispatcher's runnable like "if(queueEmpty) notify", and this is likely to be invoked in every normal execution of the dispatch while loop if queue is empty, even it's not actually in stop phase, which may create more overhead, as this AsyncDispatcher is used everywhere.
Can this be only enabled when serviceStop sets the drain events flag. In normal situations that flag will not be set.

Replacing the eventHandler to DropEventHandler (instead of GenericEventHandler) may not be enough. Someone may have already gotten a GenericEventHandler object and may send events using that object. So new events will keep getting added to the queue from those cached GenericEventHandler object. So, I think keeping track of the number of events to drain and only draining those many events will be a more robust solution.

> RMStateStore should flush all pending store events before closing
> -----------------------------------------------------------------
>
>                 Key: YARN-1121
>                 URL: https://issues.apache.org/jira/browse/YARN-1121
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: 2.1.0-beta
>            Reporter: Bikas Saha
>            Assignee: Jian He
>             Fix For: 2.2.1
>
>         Attachments: YARN-1121.1.patch, YARN-1121.2.patch, YARN-1121.2.patch, YARN-1121.3.patch, YARN-1121.4.patch, YARN-1121.5.patch, YARN-1121.6.patch, YARN-1121.6.patch
>
>
> on serviceStop it should wait for all internal pending events to drain before stopping.


--
This message was sent by Atlassian JIRA
(v6.1#6144)