Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 32AB510A4C for ; Wed, 6 Nov 2013 05:09:21 +0000 (UTC) Received: (qmail 39861 invoked by uid 500); 6 Nov 2013 05:09:19 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 39709 invoked by uid 500); 6 Nov 2013 05:09:19 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 39685 invoked by uid 99); 6 Nov 2013 05:09:18 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Nov 2013 05:09:18 +0000 Date: Wed, 6 Nov 2013 05:09:18 +0000 (UTC) From: "Vinod Kumar Vavilapalli (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-987) Adding History Service to use Store and converting Historydata to Report MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814605#comment-13814605 ] Vinod Kumar Vavilapalli commented on YARN-987: ---------------------------------------------- Quickly scanned through the patch, comments: - reduce the scope of methods like getLastAttempt, they don't need to be public. - ApplicationHistoryContext -> ApplicationHistoryManager and ApplicationHistory -> ApplicationHistoryManagerImpl. They aren't just context objects. > Adding History Service to use Store and converting Historydata to Report > ------------------------------------------------------------------------ > > Key: YARN-987 > URL: https://issues.apache.org/jira/browse/YARN-987 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Mayank Bansal > Assignee: Mayank Bansal > Attachments: YARN-987-1.patch, YARN-987-2.patch, YARN-987-3.patch, YARN-987-4.patch, YARN-987-5.patch > > -- This message was sent by Atlassian JIRA (v6.1#6144)