hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1407) RM Web UI and REST APIs should uniformly use YarnApplicationState
Date Fri, 15 Nov 2013 21:41:22 GMT

    [ https://issues.apache.org/jira/browse/YARN-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824128#comment-13824128
] 

Hadoop QA commented on YARN-1407:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12614127/YARN-1407-2.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/2463//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2463//console

This message is automatically generated.

> RM Web UI and REST APIs should uniformly use YarnApplicationState
> -----------------------------------------------------------------
>
>                 Key: YARN-1407
>                 URL: https://issues.apache.org/jira/browse/YARN-1407
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.2.0
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-1407-1.patch, YARN-1407-2.patch, YARN-1407.patch
>
>
> RMAppState isn't a public facing enum like YarnApplicationState, so we shouldn't return
values or list filters that come from it. However, some Blocks and AppInfo are still using
RMAppState.
> It is not 100% clear to me whether or not fixing this would be a backwards-incompatible
change.  The change would only reduce the set of possible strings that the API returns, so
I think not.  We have also been changing the contents of RMAppState since 2.2.0, e.g. in YARN-891.
It would still be good to fix this ASAP (i.e. for 2.2.1).



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message