hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sandy Ryza (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1403) Separate out configuration loading from QueueManager in the Fair Scheduler
Date Tue, 19 Nov 2013 00:49:21 GMT

    [ https://issues.apache.org/jira/browse/YARN-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826007#comment-13826007

Sandy Ryza commented on YARN-1403:

Uploading a new patch with the following changes:

bq. start()/stop() should set a volatile boolean 'running' to true/false & the reloadThread
should loop while 'running'. The stop() should interrupt the thread for force a wake up if

bq. reloadThread run(), the try block should include the reload, then when interrupted by
stop() would skip the reloading if exiting.
Moved the reload so that the loop's check for running comes after the sleep.

bq. reloadAllocs(), we are not charge by the character, method name should be reloadAllocations()

bq. if (allocFile == null) return; use {}

bq. what happens if reloadListener.queueConfigurationReloaded(info); throws an exception?
in what state things end up?
If it's during FairScheduler.reinitialize(), we fail.  Otherwise, we just don't update the

bq. not sure the logic using lastReloadAttemptFailed is correct, in the exception handling
in thread run()
Rechecked it and I think it's correct.  Let me know if I'm missing something.

bq. QueueConfiguration() constructor, shouldn't placementpolicy be the default?

bq. Wouldn't be simpler/cleaner if the QueueManager should be a service that encapsulates
the reloading, queue allocations, ACLs and queue placement.
The allocation configuration has a bunch of information that is not relevant to the queue
manager, e.g. user max apps and fair share preemption timeout.  I think it actually makes
more sense to move it into FairScheduler beside QueueManager.

> Separate out configuration loading from QueueManager in the Fair Scheduler
> --------------------------------------------------------------------------
>                 Key: YARN-1403
>                 URL: https://issues.apache.org/jira/browse/YARN-1403
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.2.0
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-1403-1.patch, YARN-1403-2.patch, YARN-1403.patch

This message was sent by Atlassian JIRA

View raw message