hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Abdelnur (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1403) Separate out configuration loading from QueueManager in the Fair Scheduler
Date Sat, 16 Nov 2013 00:21:21 GMT

    [ https://issues.apache.org/jira/browse/YARN-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824268#comment-13824268

Alejandro Abdelnur commented on YARN-1403:

* AllocationFileLoaderService.java:
** start()/stop() should set a volatile boolean 'running' to true/false & the reloadThread
should loop while 'running'. The stop() should interrupt the thread for force a wake up if
** reloadThread run(), the try block should include the reload, then when interrupted by stop()
would skip the reloading if exiting.
** reloadAllocs(), we are not charge by the character, method name should be reloadAllocations()
** if (allocFile == null) return; use {}
** what happens if reloadListener.queueConfigurationReloaded(info); throws an exception? in
what state things end up?
** not sure the logic using lastReloadAttemptFailed is correct, in the exception handling
in thread run()
* QueueConfiguration.java
** QueueConfiguration() constructor, shouldn't placementpolicy be the default?
* QueueManager.java
** shouldn't this be a composite service?
** it is starting but not stopping the AllocationFileLoaderService
** the initialize() setting the reload-listener is too hidden, this should be done next to
where the AllocationFileService is created.

Wouldn't be simpler/cleaner if the QueueManager should be a service that encapsulates the
reloading, queue allocations, ACLs and queue placement. And the FS should just see methods
of it.

> Separate out configuration loading from QueueManager in the Fair Scheduler
> --------------------------------------------------------------------------
>                 Key: YARN-1403
>                 URL: https://issues.apache.org/jira/browse/YARN-1403
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.2.0
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-1403-1.patch, YARN-1403.patch

This message was sent by Atlassian JIRA

View raw message