hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebastian Wong (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (YARN-1332) In TestAMRMClient, replace assertTrue with assertEquals where possible
Date Fri, 15 Nov 2013 05:09:22 GMT

     [ https://issues.apache.org/jira/browse/YARN-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sebastian Wong updated YARN-1332:
---------------------------------

    Attachment: YARN-1332.patch

Hello,

First time contributor here. I went into TestAMRMClient.java and replaced all the assertTrue(amClient.ask.size()
== 0) calls with assertEquals(0, amClient.ask.size()). 

Running the unit tests resulted in what I think is the unit tests for TestAMRMClient successfully
passing with the output:

Running org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 20.374 sec - in org.apache.hadoop.yarn.client.api.impl.TestAMRMClient

Please let me know if I did anything wrong.

Thanks, 
Sebastian

> In TestAMRMClient, replace assertTrue with assertEquals where possible
> ----------------------------------------------------------------------
>
>                 Key: YARN-1332
>                 URL: https://issues.apache.org/jira/browse/YARN-1332
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.2.0
>            Reporter: Sandy Ryza
>            Priority: Minor
>              Labels: newbie
>         Attachments: YARN-1332.patch
>
>
> TestAMRMClient uses a lot of "assertTrue(amClient.ask.size() == 0)" where "assertEquals(0,
amClient.ask.size())" would make it easier to see why it's failing at a glance.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message