hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1329) yarn-config.sh overwrites YARN_CONF_DIR indiscriminately
Date Mon, 11 Nov 2013 03:47:18 GMT

    [ https://issues.apache.org/jira/browse/YARN-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818676#comment-13818676

Hadoop QA commented on YARN-1329:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/2408//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2408//console

This message is automatically generated.

> yarn-config.sh overwrites YARN_CONF_DIR indiscriminately 
> ---------------------------------------------------------
>                 Key: YARN-1329
>                 URL: https://issues.apache.org/jira/browse/YARN-1329
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager, resourcemanager
>            Reporter: Aaron Gottlieb
>            Assignee: haosdent
>              Labels: easyfix
>         Attachments: YARN-1329.patch
> The script yarn-daemons.sh calls {code}${HADOOP_LIBEXEC_DIR}/yarn-config.sh{code}
> yarn-config.sh overwrites any previously set value of environment variable YARN_CONF_DIR
starting at line 40:
> {code:title=yarn-config.sh|borderStyle=solid}
> #check to see if the conf dir is given as an optional argument
> if [ $# -gt 1 ]
> then
>     if [ "--config" = "$1" ]
> 	  then
> 	      shift
> 	      confdir=$1
> 	      shift
> 	      YARN_CONF_DIR=$confdir
>     fi
> fi
> # Allow alternate conf dir location.
> {code}
> The last line should check for the existence of YARN_CONF_DIR first.
> {code}
> {code}

This message was sent by Atlassian JIRA

View raw message