[ https://issues.apache.org/jira/browse/YARN-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817908#comment-13817908
]
Vinod Kumar Vavilapalli commented on YARN-1121:
-----------------------------------------------
Looks good overall. Checking this in.
One thing of note is that you are removing locking for service-life-cycle methods in RMStateStore.
I verified that it seems fine - events coming in during serviceStop are ignored due to draining
and other blocking calls are okay to happen.
> RMStateStore should flush all pending store events before closing
> -----------------------------------------------------------------
>
> Key: YARN-1121
> URL: https://issues.apache.org/jira/browse/YARN-1121
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: 2.1.0-beta
> Reporter: Bikas Saha
> Assignee: Jian He
> Fix For: 2.2.1
>
> Attachments: YARN-1121.1.patch, YARN-1121.2.patch, YARN-1121.2.patch, YARN-1121.3.patch,
YARN-1121.4.patch, YARN-1121.5.patch, YARN-1121.6.patch, YARN-1121.6.patch, YARN-1121.7.patch
>
>
> on serviceStop it should wait for all internal pending events to drain before stopping.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
|