hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikas Saha (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1121) RMStateStore should flush all pending store events before closing
Date Tue, 05 Nov 2013 06:18:18 GMT

    [ https://issues.apache.org/jira/browse/YARN-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813686#comment-13813686
] 

Bikas Saha commented on YARN-1121:
----------------------------------

Code for comment above - Isnt this almost a tight loop? Given that storing stuff will be over
the network and slow, why not have a wait notify between this thread and the draining thread?
{code}
   protected void serviceStop() throws Exception {
+    if (drainingStopNeeded) {
+      drainingStop = true;
+      while(!drained) {
+        Thread.yield();
+      }
{code}

> RMStateStore should flush all pending store events before closing
> -----------------------------------------------------------------
>
>                 Key: YARN-1121
>                 URL: https://issues.apache.org/jira/browse/YARN-1121
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: 2.1.0-beta
>            Reporter: Bikas Saha
>            Assignee: Jian He
>             Fix For: 2.2.1
>
>         Attachments: YARN-1121.1.patch, YARN-1121.2.patch, YARN-1121.2.patch, YARN-1121.3.patch,
YARN-1121.4.patch, YARN-1121.5.patch
>
>
> on serviceStop it should wait for all internal pending events to drain before stopping.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message