[ https://issues.apache.org/jira/browse/YARN-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818551#comment-13818551
]
Vinod Kumar Vavilapalli commented on YARN-987:
----------------------------------------------
Mostly looks good. One final comment - shouldn't it be using the reader instead of using the
whole store interface directly? Also, call the referred object as reader instead of store?
> Adding History Service to use Store and converting Historydata to Report
> ------------------------------------------------------------------------
>
> Key: YARN-987
> URL: https://issues.apache.org/jira/browse/YARN-987
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Mayank Bansal
> Assignee: Mayank Bansal
> Attachments: YARN-987-1.patch, YARN-987-2.patch, YARN-987-3.patch, YARN-987-4.patch,
YARN-987-5.patch, YARN-987-6.patch, YARN-987-7.patch, YARN-987-8.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
|