Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Fri, 25 Oct 2013 18:28:36 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12675614.1382661369099.3893.1382725716033@arcas>
In-Reply-To: <JIRA.12675614.1382661369099@arcas>
References: <JIRA.12675614.1382661369099@arcas>
Subject: [jira] [Commented] (YARN-1351) Invalid string format in Fair
 Scheduler log warn message
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805560#comment-13805560 ] 

Hadoop QA commented on YARN-1351:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12610355/fixprnt.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/2284//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2284//console

This message is automatically generated.

> Invalid string format in Fair Scheduler log warn message
> --------------------------------------------------------
>
>                 Key: YARN-1351
>                 URL: https://issues.apache.org/jira/browse/YARN-1351
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>            Reporter: Konstantin Weitz
>         Attachments: fixprnt.patch
>
>
> While trying to print a warning, two values of the wrong type (Resource instead of int) are passed into a String.format method call, leading to a runtime exception, in the file:
> _trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java_.
> The warning was intended to be printed whenever the resources don't fit into each other, either because the number of virtual cores or the memory is too small. I changed the %d's into %s, this way the warning will contain both the cores and the memory.
> Following the patch that fixes the issue:
> Index: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java
> ===================================================================
> --- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java	(revision 1535589)
> +++ hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java	(working copy)
> @@ -471,7 +471,7 @@
>      if (maxQueueResources.containsKey(queueName) && minQueueResources.containsKey(queueName)
>          && !Resources.fitsIn(minQueueResources.get(queueName),
>              maxQueueResources.get(queueName))) {
> -      LOG.warn(String.format("Queue %s has max resources %d less than min resources %d",
> +      LOG.warn(String.format("Queue %s has max resources %s less than min resources %s",
>            queueName, maxQueueResources.get(queueName), minQueueResources.get(queueName)));
>      }
>    }


--
This message was sent by Atlassian JIRA
(v6.1#6144)