Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Fri, 25 Oct 2013 18:18:39 +0000 (UTC)
From: "Chris Nauroth (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12675590.1382655583066.3845.1382725119578@arcas>
In-Reply-To: <JIRA.12675590.1382655583066@arcas>
References: <JIRA.12675590.1382655583066@arcas>
Subject: [jira] [Commented] (YARN-1349) yarn.cmd does not support
 passthrough to any arbitrary class.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805549#comment-13805549 ] 

Chris Nauroth commented on YARN-1349:
-------------------------------------

{quote}
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{quote}

All changes are in scripts, so there are no new tests.  I manually tested this patch in a running Windows cluster by running all yarn.cmd sub-commands and one additional direct class to cover the passthrough case.

> yarn.cmd does not support passthrough to any arbitrary class.
> -------------------------------------------------------------
>
>                 Key: YARN-1349
>                 URL: https://issues.apache.org/jira/browse/YARN-1349
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 3.0.0, 2.2.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: YARN-1349.1.patch, YARN-1349.2.patch
>
>
> The yarn shell script supports passthrough to calling any arbitrary class if the first argument is not one of the per-defined sub-commands.  The equivalent cmd script does not implement this and instead fails trying to do a labeled goto to the first argument.


--
This message was sent by Atlassian JIRA
(v6.1#6144)