Return-Path: 
 <yarn-issues-return-16355-apmail-hadoop-yarn-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 8197D10246
	for <apmail-hadoop-yarn-issues-archive@minotaur.apache.org>;
 Fri, 11 Oct 2013 03:35:05 +0000 (UTC)
Received: (qmail 87500 invoked by uid 500); 11 Oct 2013 03:34:53 -0000
Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org
Received: (qmail 87437 invoked by uid 500); 11 Oct 2013 03:34:47 -0000
Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:yarn-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:yarn-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:yarn-issues@hadoop.apache.org>
List-Id: <yarn-issues.hadoop.apache.org>
Reply-To: yarn-issues@hadoop.apache.org
Delivered-To: mailing list yarn-issues@hadoop.apache.org
Received: (qmail 87407 invoked by uid 99); 11 Oct 2013 03:34:43 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Oct 2013 03:34:43 +0000
Date: Fri, 11 Oct 2013 03:34:42 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12673360.1381459687483.49641.1381462482936@arcas>
In-Reply-To: <JIRA.12673360.1381459687483@arcas>
References: <JIRA.12673360.1381459687483@arcas>
Subject: [jira] [Commented] (YARN-1296) schedulerAllocateTimer is accessed
 without holding samplerLock in ResourceSchedulerWrapper
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/YARN-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13792303#comment-13792303 ] 

Ted Yu commented on YARN-1296:
------------------------------

I found these two fair-scheduler-allocation.xml :

./hadoop-tools/hadoop-sls/src/main/sample-conf/fair-scheduler-allocation.xml
./hadoop-tools/hadoop-sls/src/test/resources/fair-scheduler-allocation.xml

But they seem to have '<allocations>' as top-level element.

> schedulerAllocateTimer is accessed without holding samplerLock in ResourceSchedulerWrapper
> ------------------------------------------------------------------------------------------
>
>                 Key: YARN-1296
>                 URL: https://issues.apache.org/jira/browse/YARN-1296
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>         Attachments: yarn-1296-v1.patch
>
>
> Here is related code:
> {code}
>   public Allocation allocate(ApplicationAttemptId attemptId,
>                              List<ResourceRequest> resourceRequests,
>                              List<ContainerId> containerIds,
>                              List<String> strings, List<String> strings2) {
>     if (metricsON) {
>       final Timer.Context context = schedulerAllocateTimer.time();
> {code}
> samplerLock should be used to guard the access.



--
This message was sent by Atlassian JIRA
(v6.1#6144)