Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A9AFD10354 for ; Wed, 23 Oct 2013 21:13:39 +0000 (UTC) Received: (qmail 26123 invoked by uid 500); 23 Oct 2013 21:13:01 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 26020 invoked by uid 500); 23 Oct 2013 21:12:48 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 25992 invoked by uid 99); 23 Oct 2013 21:12:47 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Oct 2013 21:12:47 +0000 Date: Wed, 23 Oct 2013 21:12:46 +0000 (UTC) From: "Mayank Bansal (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-956) [YARN-321] Add a testable in-memory HistoryStorage MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803340#comment-13803340 ] Mayank Bansal commented on YARN-956: ------------------------------------ Thanks [~vinodkv] for the review. Earlier I had the same discussion with [~zjshen] offline and I pointed the same point for static variables. Zhijie convinced me for static saying that we should only have one store per system. I think there is a point to that because if somebody just wants to use the memory store for some reason for AHS then it would be very hard for us to support. Else we have to tell them memory store is just for testing and if they want to use something like that then they have to write their own store. Thanks, Mayank > [YARN-321] Add a testable in-memory HistoryStorage > --------------------------------------------------- > > Key: YARN-956 > URL: https://issues.apache.org/jira/browse/YARN-956 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Vinod Kumar Vavilapalli > Assignee: Zhijie Shen > Fix For: YARN-321 > > Attachments: YARN-956-1.patch, YARN-956-2.patch, YARN-956-3.patch, YARN-956.4.patch, YARN-956.5.patch, YARN-956.6.patch > > -- This message was sent by Atlassian JIRA (v6.1#6144)