hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhijie Shen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1328) ContainerId should expose a public static string of the ID's prefix
Date Mon, 21 Oct 2013 01:54:42 GMT

    [ https://issues.apache.org/jira/browse/YARN-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13800302#comment-13800302
] 

Zhijie Shen commented on YARN-1328:
-----------------------------------

bq. IMO, we should use snake case with upper case like CONTAINER_ID_PREFIX instead of using
camel case when we define constants. I think appIdStrPrefix/appAttemptIdStrPrefix should also
be fixed.

Yes, the upper case is pretty standard for naming the final static variables. However, due
to some reasons, ApplicationId and ApplicationAttemptId doesn't follow it. I'd like keep the
consistency in  ContainerId as well. In contrast, I'm conservative to change appIdStrPrefix/appAttemptIdStrPrefix
as they are open to the users. Therefore the change may affect the existing users, in particular
after GA release.

> ContainerId should expose a public static string of the ID's prefix
> -------------------------------------------------------------------
>
>                 Key: YARN-1328
>                 URL: https://issues.apache.org/jira/browse/YARN-1328
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>            Priority: Minor
>         Attachments: YARN-1328.1.patch
>
>
> Like ApplicationId and ApplicationAttemptId, ContainerId should also have public static
string:
> {code}
>   public static final String containerIdStrPrefix = "container_";
> {code}
> Others can refer to this string to verify a containerId string.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message