hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikas Saha (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1305) RMHAProtocolService#serviceInit should handle HAUtil's IllegalArgumentException
Date Wed, 16 Oct 2013 15:19:42 GMT

    [ https://issues.apache.org/jira/browse/YARN-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796879#comment-13796879
] 

Bikas Saha commented on YARN-1305:
----------------------------------

First of all, how do we hit the original bug? Resource manager addresses have default values
and so they should not end up being null even if they are not setup by the user.

About the patch
Is there a way to pass the original exception inside the badconfiguration exception?
Can we make the error message more generic? e.g. invalid value of rm_ha_id.
{code}
+      if (confKey == null) {
+        // Error at addSuffix
+        errmsg = YarnConfiguration.RM_HA_ID +
+          " cannot be allowed to start with '.'";
{code}
Why do we need to log the current conf value in the error?
{code}
+        // Error at Configuration#set
+        errmsg =  confKey + " needs to be set correctly" +
+          "in a HA configuration. Configured value is: " + confValue;
{code}

> RMHAProtocolService#serviceInit should handle HAUtil's IllegalArgumentException
> -------------------------------------------------------------------------------
>
>                 Key: YARN-1305
>                 URL: https://issues.apache.org/jira/browse/YARN-1305
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: 2.2.1
>            Reporter: Tsuyoshi OZAWA
>            Assignee: Tsuyoshi OZAWA
>              Labels: ha
>         Attachments: YARN-1305.1.patch, YARN-1305.2.patch
>
>
> When yarn.resourcemanager.ha.enabled is true, RMHAProtocolService#serviceInit calls HAUtil.setAllRpcAddresses.
If the configuration values are null, it just throws IllegalArgumentException.
> It's messy to analyse which keys are null, so we should handle it and log the name of
keys which are null.
> A current log dump is as follows:
> {code}
> 2013-10-15 06:24:53,431 INFO org.apache.hadoop.yarn.server.resourcemanager.ResourceManager:
registered UNIX signal handlers for [TERM, HUP, INT]
> 2013-10-15 06:24:54,203 INFO org.apache.hadoop.service.AbstractService: Service RMHAProtocolService
failed in state INITED; cause: java.lang.IllegalArgumentException: Property value must not
be null
> java.lang.IllegalArgumentException: Property value must not be null
>         at com.google.common.base.Preconditions.checkArgument(Preconditions.java:88)
>         at org.apache.hadoop.conf.Configuration.set(Configuration.java:816)
>         at org.apache.hadoop.conf.Configuration.set(Configuration.java:798)
>         at org.apache.hadoop.yarn.conf.HAUtil.setConfValue(HAUtil.java:100)
>         at org.apache.hadoop.yarn.conf.HAUtil.setAllRpcAddresses(HAUtil.java:105)
>         at org.apache.hadoop.yarn.server.resourcemanager.RMHAProtocolService.serviceInit(RMHAProtocolService.java:60)
>         at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
>         at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:108)
>         at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.serviceInit(ResourceManager.java:187)
>         at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
>         at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.main(ResourceManager.java:940)
> {code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message