hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsuyoshi OZAWA (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (YARN-1305) RMHAProtocolService#serviceInit should handle HAUtil's IllegalArgumentException
Date Tue, 22 Oct 2013 01:47:43 GMT

     [ https://issues.apache.org/jira/browse/YARN-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Tsuyoshi OZAWA updated YARN-1305:

    Attachment: YARN-1305.8.patch

Thank you too, Bikas. The code quality gets better and better :-)
This patch reflects the latest review comment by Bikas:

1. Converted all verify* methods to verifyAndSet* methods. verifyAndSet* verify the value,
and sets verified and trimmed value to Configuration instance.
2. Converted all the @VisibleForTesting methods to package private instead of public.
3. Changed getRMId() and getRMIds() to just return set value instead of calling getTrimmed()
and throwing BadConfigurationException. Therefore, testGetRMId() asserts returning null value
when configuration is empty.
4. Introdued *_TRIMMED values instead of using trim().

> RMHAProtocolService#serviceInit should handle HAUtil's IllegalArgumentException
> -------------------------------------------------------------------------------
>                 Key: YARN-1305
>                 URL: https://issues.apache.org/jira/browse/YARN-1305
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: 2.2.1
>            Reporter: Tsuyoshi OZAWA
>            Assignee: Tsuyoshi OZAWA
>              Labels: ha
>         Attachments: YARN-1305.1.patch, YARN-1305.2.patch, YARN-1305.3.patch, YARN-1305.4.patch,
YARN-1305.5.patch, YARN-1305.6.patch, YARN-1305.7.patch, YARN-1305.8.patch
> When yarn.resourcemanager.ha.enabled is true, RMHAProtocolService#serviceInit calls HAUtil.setAllRpcAddresses.
If the configuration values are null, it just throws IllegalArgumentException.
> It's messy to analyse which keys are null, so we should handle it and log the name of
keys which are null.
> A current log dump is as follows:
> {code}
> 2013-10-15 06:24:53,431 INFO org.apache.hadoop.yarn.server.resourcemanager.ResourceManager:
registered UNIX signal handlers for [TERM, HUP, INT]
> 2013-10-15 06:24:54,203 INFO org.apache.hadoop.service.AbstractService: Service RMHAProtocolService
failed in state INITED; cause: java.lang.IllegalArgumentException: Property value must not
be null
> java.lang.IllegalArgumentException: Property value must not be null
>         at com.google.common.base.Preconditions.checkArgument(Preconditions.java:88)
>         at org.apache.hadoop.conf.Configuration.set(Configuration.java:816)
>         at org.apache.hadoop.conf.Configuration.set(Configuration.java:798)
>         at org.apache.hadoop.yarn.conf.HAUtil.setConfValue(HAUtil.java:100)
>         at org.apache.hadoop.yarn.conf.HAUtil.setAllRpcAddresses(HAUtil.java:105)
>         at org.apache.hadoop.yarn.server.resourcemanager.RMHAProtocolService.serviceInit(RMHAProtocolService.java:60)
>         at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
>         at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:108)
>         at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.serviceInit(ResourceManager.java:187)
>         at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
>         at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.main(ResourceManager.java:940)
> {code}

This message was sent by Atlassian JIRA

View raw message