hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikas Saha (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1232) Configuration to support multiple RMs
Date Thu, 03 Oct 2013 18:46:42 GMT

    [ https://issues.apache.org/jira/browse/YARN-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13785428#comment-13785428
] 

Bikas Saha commented on YARN-1232:
----------------------------------

Sorry. My bad. I got confused.

Patch looks good overall.

This should either be RM_ID = RM_PREFIX+"id" or RM_HA_ID = RM_HA_PREFIX+"id"  Lets be consistent.
{code}
+  public static final String RM_ID = RM_HA_PREFIX + "id";
{code}

Wherever possible, can we simply always call HAUtil methods and let HAUtil handle the if/else.
This would help reduce a bunch of if-else blocks scattered in the code.
{code}
+    if (HAUtil.isHAEnabled(this)) {
+      address = HAUtil.getConfValueForRMId(name, defaultAddress, this);
+    } else {
+      address = get(name, defaultAddress);
+    }
{code}

Let make a mental note, that when new AlwaysOn services (say RPC) are added then they need
to use the updated conf.
{code}
+  void setConf(Configuration configuration) {
+    conf = configuration;
+  }
{code}

Minor nits
getRMServiceIds() getRMId() - would help if they both had service or skipped service in the
name.

getConfValueForRMId(String prefix/getConfValueForRMId(String prefix/setConfValue(String prefix
- String rmId instead of prefix?


> Configuration to support multiple RMs
> -------------------------------------
>
>                 Key: YARN-1232
>                 URL: https://issues.apache.org/jira/browse/YARN-1232
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>              Labels: ha
>         Attachments: yarn-1232-1.patch, yarn-1232-2.patch, yarn-1232-3.patch, yarn-1232-4.patch,
yarn-1232-5.patch, yarn-1232-6.patch
>
>
> We should augment the configuration to allow users specify two RMs and the individual
RPC addresses for them.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message