hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hitesh Shah (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1131) $ yarn logs should return a message log aggregation is during progress if YARN application is running
Date Thu, 03 Oct 2013 05:26:52 GMT

    [ https://issues.apache.org/jira/browse/YARN-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13784836#comment-13784836
] 

Hitesh Shah commented on YARN-1131:
-----------------------------------

Comments:
  - why not use Option.setRequired for the applicationId param - this will allow removal of
the appIdStr == null check.
  - typo in function name "dumpAContainersLogs" or is it meant to read dump a container's
logs? Maybe just dumpContainerLogs? 
  - containerIdStr and nodeAddressStr could be parsed for correct format to error out earlier
before invoking the actual log reader functionality. 
  - is a YarnApplicationState check enough to guarantee that the user receives the correct
error message in case logs are tried to be retrieved when log aggregration is still in process
just after the app completes? 
  - missing test for when container id specified but node address is not ( and vice versa
) ?
 



> $ yarn logs should return a message log aggregation is during progress if YARN application
is running
> -----------------------------------------------------------------------------------------------------
>
>                 Key: YARN-1131
>                 URL: https://issues.apache.org/jira/browse/YARN-1131
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client
>    Affects Versions: 2.1.1-beta
>            Reporter: Tassapol Athiapinya
>            Assignee: Siddharth Seth
>            Priority: Minor
>         Attachments: YARN-1131.1.txt
>
>
> In the case when log aggregation is enabled, if a user submits MapReduce job and runs
$ yarn logs -applicationId <app ID> while the YARN application is running, the command
will return no message and return user back to shell. It is nice to tell the user that log
aggregation is in progress.
> {code}
> -bash-4.1$ /usr/bin/yarn logs -applicationId application_1377900193583_0002
> -bash-4.1$
> {code}
> At the same time, if invalid application ID is given, YARN CLI should say that the application
ID is incorrect rather than throwing NoSuchElementException.
> {code}
> $ /usr/bin/yarn logs -applicationId application_00000
> Exception in thread "main" java.util.NoSuchElementException
> at com.google.common.base.AbstractIterator.next(AbstractIterator.java:75)
> at org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:124)
> at org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:119)
> at org.apache.hadoop.yarn.logaggregation.LogDumper.run(LogDumper.java:110)
> at org.apache.hadoop.yarn.logaggregation.LogDumper.main(LogDumper.java:255)
> {code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message