hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikas Saha (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1068) Add admin support for HA operations
Date Tue, 15 Oct 2013 20:45:44 GMT

    [ https://issues.apache.org/jira/browse/YARN-1068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13795610#comment-13795610
] 

Bikas Saha commented on YARN-1068:
----------------------------------

Looks good to me. Will give a day or so for some other committers to take a look.

There isnt any need for this to wrap the IOException in another exception. The base AdminService
protocol signature already supports throwing IOException. (ResourceManagerAdministrationProtocol).
If its small enough, we could fix it this here or do it in a separate jira.
{code}
   private UserGroupInformation checkAcls(String method) throws YarnException {
-    UserGroupInformation user;
     try {
-      user = UserGroupInformation.getCurrentUser();
+      return RMServerUtils.verifyAccess(adminAcl, method, LOG);
     } catch (IOException ioe) {
-      LOG.warn("Couldn't get current user", ioe);
-
-      RMAuditLogger.logFailure("UNKNOWN", method,
-          adminAcl.toString(), "AdminService",
-          "Couldn't get current user");
       throw RPCUtil.getRemoteException(ioe);
     }
{code}

> Add admin support for HA operations
> -----------------------------------
>
>                 Key: YARN-1068
>                 URL: https://issues.apache.org/jira/browse/YARN-1068
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: 2.1.0-beta
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>              Labels: ha
>         Attachments: yarn-1068-10.patch, yarn-1068-11.patch, yarn-1068-1.patch, yarn-1068-2.patch,
yarn-1068-3.patch, yarn-1068-4.patch, yarn-1068-5.patch, yarn-1068-6.patch, yarn-1068-7.patch,
yarn-1068-8.patch, yarn-1068-9.patch, yarn-1068-prelim.patch
>
>
> Support HA admin operations to facilitate transitioning the RM to Active and Standby
states.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message