hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ravi Prakash (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-465) fix coverage org.apache.hadoop.yarn.server.webproxy
Date Sun, 06 Oct 2013 16:14:43 GMT

    [ https://issues.apache.org/jira/browse/YARN-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787658#comment-13787658
] 

Ravi Prakash commented on YARN-465:
-----------------------------------

Thanks for the updates and answers Andrey!
I could not find a WebAppProxy.start() method. I don't see the problem in calling the main
method from tests. I would prefer that more than changing src/main code to suit tests. Removing
the proxy.join() method makes the main() thread not wait for the proxy server thread to exit.
I guess that could also be another way to do things but I am just wary of changing src/main
code without good reason for the purpose of writing unit tests.
Please correct me if I am wrong, port will always be 0 at the time it is being printed out
in the last Log.info in the start() method.
I am satisfied with the other changes. Thanks a lot for them. I am not going to be a stickler
for the above issues, so I'm going to give the trunk patch a +1.
branch-2 still has the "answer=3" option, and maybe we can add it to trunk or remove it from
branch-2. What do you think?

> fix coverage  org.apache.hadoop.yarn.server.webproxy
> ----------------------------------------------------
>
>                 Key: YARN-465
>                 URL: https://issues.apache.org/jira/browse/YARN-465
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 3.0.0, 0.23.7, 2.0.4-alpha
>            Reporter: Aleksey Gorshkov
>            Assignee: Andrey Klochkov
>         Attachments: YARN-465-branch-0.23-a.patch, YARN-465-branch-0.23.patch, YARN-465-branch-2-a.patch,
YARN-465-branch-2--n3.patch, YARN-465-branch-2--n4.patch, YARN-465-branch-2.patch, YARN-465-trunk-a.patch,
YARN-465-trunk--n3.patch, YARN-465-trunk--n4.patch, YARN-465-trunk.patch
>
>
> fix coverage  org.apache.hadoop.yarn.server.webproxy
> patch YARN-465-trunk.patch for trunk
> patch YARN-465-branch-2.patch for branch-2
> patch YARN-465-branch-0.23.patch for branch-0.23
> There is issue in branch-0.23 . Patch does not creating .keep file.
> For fix it need to run commands:
> mkdir yhadoop-common/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/proxy
> touch yhadoop-common/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/proxy/.keep




--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message