Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 24CE4109BB for ; Wed, 4 Sep 2013 19:00:53 +0000 (UTC) Received: (qmail 6271 invoked by uid 500); 4 Sep 2013 19:00:52 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 6234 invoked by uid 500); 4 Sep 2013 19:00:52 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 6218 invoked by uid 99); 4 Sep 2013 19:00:52 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Sep 2013 19:00:52 +0000 Date: Wed, 4 Sep 2013 19:00:52 +0000 (UTC) From: "Daryn Sharp (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-1146) RM DTSM and RMStateStore mismanage sequence number MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758184#comment-13758184 ] Daryn Sharp commented on YARN-1146: ----------------------------------- [~vinodkv] I'm desynch'ing the ADTSM on HADOOP-9930. Is it ok for me to exasperate this seq number handling? > RM DTSM and RMStateStore mismanage sequence number > -------------------------------------------------- > > Key: YARN-1146 > URL: https://issues.apache.org/jira/browse/YARN-1146 > Project: Hadoop YARN > Issue Type: Bug > Affects Versions: 2.0.0-alpha > Reporter: Daryn Sharp > > {{RMDelegationTokenSecretManager}} implements {{storeNewToken}} and {{updateStoredToken}} (renew) to pass the token and its sequence number to {{RMStateStore#storeRMDelegationTokenAndSequenceNumber}}. > There are two problems: > # The assumption is that new tokens will be synchronously stored in-order. With an async secret manager this may not hold true and the state's sequence number may be incorrect. > # A token renewal will reset the state's sequence number to _that token's_ sequence number. > Bug #2 is generally masked. Creating a new token (with the first caveat) will bump the state's sequence number back up. Restoring the dtsm will first set the state's stored sequence number, then re-add all the tokens which will update the sequence number if the token's sequence number is greater than the dtsm's current sequence number. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira