hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Srimanth Gunturi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1166) YARN 'appsFailed' metric should be of type 'counter'
Date Thu, 12 Sep 2013 18:09:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765716#comment-13765716
] 

Srimanth Gunturi commented on YARN-1166:
----------------------------------------

Isnt the fix as simple as changing {{appsFailed}} type to {{MutableCounterInt}}, and removing
the below?
{code}
else {
   appsFailed.decr();
}
{code}

This would make appsFailed cumulative, as in {{finishApp(AppSchedulingInfo, RMAppAttemptState)}}
we do the {{appsFailed.incr()}} on the final attempt state?
                
> YARN 'appsFailed' metric should be of type 'counter'
> ----------------------------------------------------
>
>                 Key: YARN-1166
>                 URL: https://issues.apache.org/jira/browse/YARN-1166
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.1.0-beta
>            Reporter: Srimanth Gunturi
>            Assignee: Akira AJISAKA
>            Priority: Blocker
>         Attachments: YARN-1166.2.patch, YARN-1166.3.patch, YARN-1166.patch
>
>
> Currently in YARN's queue metrics, the cumulative metric 'appsFailed' is of type 'guage'
- which means the exact value will be reported. 
> All other cumulative queue metrics (AppsSubmitted, AppsCompleted, AppsKilled) are all
of type 'counter' - meaning Ganglia will use slope to provide deltas between time-points.
> To be consistent, AppsFailed metric should also be of type 'counter'. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message