hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikas Saha (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1065) NM should provide AuxillaryService data to the container
Date Tue, 03 Sep 2013 20:47:52 GMT

    [ https://issues.apache.org/jira/browse/YARN-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757052#comment-13757052
] 

Bikas Saha commented on YARN-1065:
----------------------------------

Shouldn't it be transparent to the user and done all the time instead of depending on the
user to use the prefix?
{code}
+public class AuxiliaryServiceHelper {
+
+  public static String NM_AUX_SERVICE = "NM_AUX_SERVICE_";
...
+      AuxiliaryServiceHelper.setServiceDataIntoEnv(
+          AuxiliaryServiceHelper.NM_AUX_SERVICE + meta.getKey(),
+          meta.getValue(), environment);
{code}

There is another place in code where we can use the new method call. Its where startContainersResponse
is being created.
{code}
+  public Map<String, ByteBuffer> getAuxServiceMetaData() {
+    return this.auxiliaryServices.getMetaData();
{code}

Can we use a non specific name here?
{code}
+        serviceData.put("TezService",
+            ByteBuffer.wrap("TezServiceMetaData".getBytes()));
+        return serviceData;
{code}

Shouldnt the tests make sure that the basic functionality is working by checking that getServiceDataFromEnv()
obtains the stuff that has been set via setServiceDataIntoEnv()? Dont see anything that verifies
this.

                
> NM should provide AuxillaryService data to the container
> --------------------------------------------------------
>
>                 Key: YARN-1065
>                 URL: https://issues.apache.org/jira/browse/YARN-1065
>             Project: Hadoop YARN
>          Issue Type: Task
>            Reporter: Bikas Saha
>            Assignee: Xuan Gong
>         Attachments: YARN-1065.1.patch, YARN-1065.2.patch, YARN-1065.3.patch, YARN-1065.4.patch,
YARN-1065.5.patch
>
>
> Start container returns auxillary service data to the AM but does not provide the same
information to the task itself. It could add that information to the container env with key=service_name
and value=service_data. This allows the container to start using the service without having
to depend on the AM to send the info to it indirectly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message