hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuan Gong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-978) [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
Date Wed, 11 Sep 2013 02:55:53 GMT

    [ https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13763898#comment-13763898
] 

Xuan Gong commented on YARN-978:
--------------------------------

bq.FINISHING to FINISHED is a bad merge, and indeed is a bug, will file a ticket. But agree
with the general sentiment. LAUNCHED_UNMANAGED_SAVING can be mapped to ALLOCATED_SAVING, I
actually think we don't need a separate LAUNCHED_UNMANAGED_SAVING, Unmanaged AM should directly
go to ALLOCATED state on app-submission, will file a bug. The rest seem fine enough for me.

Fixed. Now YarnApplicationAttemptState has FINISHED and FINISHING. Also mapping RMAppAttemptState.
LAUNCHED_UNMANAGED_SAVING to YarnApplicationAttemptState. ALLOCATED_SAVING

bq. I think we should add the host and port information for information purposes so that users
can reason where their previous AMs ran and on what ports. The tracking url can be removed,
instead a logs-url can be added like we have on the UI.

Added host, rpc_port and logsUrl to applicationAttemptReport

bq.No need to add more stuff to BuilderUtils. It was supposed to be dismantled.

Removed

bq.Do we really need the prefix APP_ATTEMPT_ in YarnApplicationAttemptStateProto?

Yes, we have to. Just like we added APP prefix in FinalApplicationStatusProto. The reason
is in protocolbuffers, enum values use C++ scoping rules, meaning that enum values are siblings
of their type, not children of it.  all enum values must be unique within the global scope,
not just within "YarnApplicationAttemptStateProto".
                
> [YARN-321] Adding ApplicationAttemptReport and Protobuf implementation
> ----------------------------------------------------------------------
>
>                 Key: YARN-978
>                 URL: https://issues.apache.org/jira/browse/YARN-978
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Mayank Bansal
>            Assignee: Xuan Gong
>             Fix For: YARN-321
>
>         Attachments: YARN-978-1.patch, YARN-978.2.patch, YARN-978.3.patch, YARN-978.4.patch,
YARN-978.5.patch, YARN-978.6.patch
>
>
> We dont have ApplicationAttemptReport and Protobuf implementation.
> Adding that.
> Thanks,
> Mayank

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message