hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-353) Add Zookeeper-based store implementation for RMStateStore
Date Mon, 16 Sep 2013 20:32:55 GMT

    [ https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768721#comment-13768721
] 

Karthik Kambatla commented on YARN-353:
---------------------------------------

Thanks again for the detailed review, [~hitesh]. Sorry for the slow turnaround on this. 

{quote}
{code}
} catch (Exception e) {
  e.printStackTrace();
  Assert.fail("ZKRMStateStore Session restore failed");
}
{code}
{quote}
bq. Don't think there is any need to catch the exception. The unit test will fail if the exception
is not caught.

Agree. The difference is in what the test reports shows this as - Failure or Error. The general
rule I try to follow is - errors encountered in the specific code we are testing should be
marked failures. I am not particular about this though, let me know if you would like me to
make that change as well. The updated patch addresses some of these inconsistencies as well.
                
> Add Zookeeper-based store implementation for RMStateStore
> ---------------------------------------------------------
>
>                 Key: YARN-353
>                 URL: https://issues.apache.org/jira/browse/YARN-353
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Hitesh Shah
>            Assignee: Karthik Kambatla
>         Attachments: YARN-353.10.patch, YARN-353.11.patch, YARN-353.12.patch, yarn-353-12-wip.patch,
YARN-353.13.patch, YARN-353.14.patch, YARN-353.15.patch, YARN-353.16.patch, YARN-353.1.patch,
YARN-353.2.patch, YARN-353.3.patch, YARN-353.4.patch, YARN-353.5.patch, YARN-353.6.patch,
YARN-353.7.patch, YARN-353.8.patch, YARN-353.9.patch
>
>
> Add store that write RM state data to ZK

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message