hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Abdelnur (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-311) Dynamic node resource configuration: core scheduler changes
Date Tue, 03 Sep 2013 13:42:53 GMT

    [ https://issues.apache.org/jira/browse/YARN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756614#comment-13756614
] 

Alejandro Abdelnur commented on YARN-311:
-----------------------------------------

* the patch as a few false changes (formatting)
* RMNodeImpl#setTotalCapability() is modifying the existing resource instead assigning the
received one? is that intentional? If so, the locking is kind of pointless as holders of a
RMNodeImpl reference will see an inconsistent/non-locked value.
* the SchedulerNode#updateAvailableResource() method name is not clear with respect of a delta
correction happening (which is clear with the formal parameter name). Either we should make
the method name more obvious of we should set the new value. It is kind of confusing that
for RMNodeImpl the patch uses the full new capacity while for SchedulerNode the patch uses
the delta change; could we use full or delta values in both?

Also, in this patch it seems the change will be triggered from a NM heartbeat. Under witch
situation a NM would do such change without being restarted? If seems to me the change should
come from an admin API to the RM, this would be set as a correction in the RMNodeImpl, and
the RMNodeImpl would use the correct valued as the total instead of the total reported by
the NM. Am I missing something?
                
> Dynamic node resource configuration: core scheduler changes
> -----------------------------------------------------------
>
>                 Key: YARN-311
>                 URL: https://issues.apache.org/jira/browse/YARN-311
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager, scheduler
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: YARN-311-v1.patch, YARN-311-v2.patch, YARN-311-v3.patch, YARN-311-v4.patch,
YARN-311-v4.patch, YARN-311-v5.patch
>
>
> As the first step, we go for resource change on RM side and expose admin APIs (admin
protocol, CLI, REST and JMX API). In this jira, we will only contain changes in scheduler.
> For design details, please refer proposal and discussions in parent JIRA: YARN-291.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message