Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 965D01024B for ; Thu, 29 Aug 2013 00:11:53 +0000 (UTC) Received: (qmail 75949 invoked by uid 500); 29 Aug 2013 00:11:53 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 75921 invoked by uid 500); 29 Aug 2013 00:11:53 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 75908 invoked by uid 99); 29 Aug 2013 00:11:53 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Aug 2013 00:11:53 +0000 Date: Thu, 29 Aug 2013 00:11:53 +0000 (UTC) From: "Karthik Kambatla (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-1075) AsyncDispatcher and ResourceTrackerService violate serviceStart() semantics MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753076#comment-13753076 ] Karthik Kambatla commented on YARN-1075: ---------------------------------------- [~vinodkv], [~stevel@apache.org]: what do you think? Should I still go ahead and close this as invalid? > AsyncDispatcher and ResourceTrackerService violate serviceStart() semantics > --------------------------------------------------------------------------- > > Key: YARN-1075 > URL: https://issues.apache.org/jira/browse/YARN-1075 > Project: Hadoop YARN > Issue Type: Bug > Affects Versions: 2.1.0-beta > Reporter: Karthik Kambatla > Assignee: Karthik Kambatla > Priority: Minor > Attachments: yarn-1075-1.patch > > > IIUC, the serviceStart() implementation of services should start local threads/services first before calling super.serviceStart(). Certain services have this reversed as below - leading to possibilities where the service would be in state STARTED, but in reality might not have started yet. > {code} > void serviceStart() { > super.serviceStart() > // service sepecific logic and start operations > } > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira