hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Siddharth Seth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1045) Improve toString implementation for PBImpls
Date Thu, 08 Aug 2013 20:22:50 GMT

    [ https://issues.apache.org/jira/browse/YARN-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13733934#comment-13733934
] 

Siddharth Seth commented on YARN-1045:
--------------------------------------

Thanks for taking this up Jian. Did you get a chance to run all MR and YARN unit tests locally
 - in case we're relying on the toString format anywhere.
                
> Improve toString implementation for PBImpls
> -------------------------------------------
>
>                 Key: YARN-1045
>                 URL: https://issues.apache.org/jira/browse/YARN-1045
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.0.4-alpha
>            Reporter: Siddharth Seth
>            Assignee: Jian He
>         Attachments: YARN-1045.patch
>
>
> The generic toString implementation that is used in most of the PBImpls {code}getProto().toString().replaceAll("\\n",
", ").replaceAll("\\s+", " ");{code} is rather inefficient - replacing "\n" and "\s" to generate
a one line string. Instead, we can use {code}TextFormat.shortDebugString(getProto());{code}.
> If we can get this into 2.1.0 - great, otherwise the next release.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message